[MI-2814] Done the review fixes of github PR #636 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Improved code readability
1. Fixed linting errors
1. Fixed linting error
1. Improved code readability
1. Changed the case of few endpoints to snake case
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
1. Made comment field editable when trying to add a comment from message action.
webapp/src/components/modals/attach_comment_to_issue/attach_comment_to_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Show resolved
Hide resolved
Kshitij-Katiyar
approved these changes
Mar 10, 2023
1. Improved code readability
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
webapp/src/components/modals/create_update_issue/create_update_issue.jsx
Outdated
Show resolved
Hide resolved
1. Used GET method on getting the issue info 2. Improved code readability
manojmalik20
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #636